Return-Path: 
 <dev-return-76848-apmail-cloudstack-dev-archive=cloudstack.apache.org@cloudstack.apache.org>
X-Original-To: apmail-cloudstack-dev-archive@www.apache.org
Delivered-To: apmail-cloudstack-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 92E6818AF3
	for <apmail-cloudstack-dev-archive@www.apache.org>;
 Thu, 16 Jul 2015 04:51:00 +0000 (UTC)
Received: (qmail 13368 invoked by uid 500); 16 Jul 2015 04:51:00 -0000
Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org
Received: (qmail 13311 invoked by uid 500); 16 Jul 2015 04:51:00 -0000
Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cloudstack.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cloudstack.apache.org>
List-Post: <mailto:dev@cloudstack.apache.org>
List-Id: <dev.cloudstack.apache.org>
Reply-To: dev@cloudstack.apache.org
Delivered-To: mailing list dev@cloudstack.apache.org
Received: (qmail 13300 invoked by uid 99); 16 Jul 2015 04:50:59 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jul 2015 04:50:59 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 84CB3E091F; Thu, 16 Jul 2015 04:50:59 +0000 (UTC)
From: bhaisaab <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-580-cloudstack@git.apache.org>
In-Reply-To: <git-pr-580-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable
 Fencing whe...
Content-Type: text/plain
Message-Id: <20150716045059.84CB3E091F@git1-us-west.apache.org>
Date: Thu, 16 Jul 2015 04:50:59 +0000 (UTC)

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/580#discussion_r34755639
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtFenceCommandWrapper.java ---
    @@ -48,6 +48,18 @@ public Answer execute(final FenceCommand command, final LibvirtComputingResource
             final KVMHAMonitor monitor = libvirtComputingResource.getMonitor();
     
             final List<NfsStoragePool> pools = monitor.getStoragePools();
    +
    +        /**
    +         * We can only safely fence off hosts when we use NFS
    +         * On NFS primary storage pools hosts continuesly write
    +         * a heartbeat. Disable Fencing Off for hosts without NFS
    +         */
    +        if (pools.size() == 0) {
    +            String logline = "No NFS storage pools found. No way to safely fence " + command.getVmName() + " on host " + command.getHostGuid();
    --- End diff --
    
    maybe add an alert for admin here, _alertMgr.sendAlert?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---