Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: bhaisaab <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-587-cloudstack@git.apache.org>
In-Reply-To: <git-pr-587-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with
 both ...
Content-Type: text/plain
Message-Id: <20150714151705.A0CEBE1126@git1-us-west.apache.org>
Date: Tue, 14 Jul 2015 15:17:05 +0000 (UTC)

Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/587#discussion_r34579656
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/templates/check_heartbeat.sh.templ ---
    @@ -47,13 +47,14 @@ then
         if [ $s -gt 2 ]
         then
             echo Keepalived process is dead! >> $ROUTER_LOG
    -        $ROUTER_BIN_PATH/services.sh stop >> $ROUTER_LOG 2>&1
    -        $ROUTER_BIN_PATH/disable_pubip.sh >> $ROUTER_LOG 2>&1
    -        $ROUTER_BIN_PATH/primary-backup.sh fault >> $ROUTER_LOG 2>&1
             service keepalived stop >> $ROUTER_LOG 2>&1
             service conntrackd stop >> $ROUTER_LOG 2>&1
    -	pkill -9 keepalived >> $ROUTER_LOG 2>&1
    -	pkill -9 conntrackd >> $ROUTER_LOG 2>&1
    +        
    +        #Set fault so we have the same effect as a KeepaliveD fault.
    +        python /opt/cloud/bin/master.py --fault
    --- End diff --
    
    will running the script here block this shell script until it exists, or will it launch as a daemon? If it's blocking then it's alright.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---