Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: wilderrodrigues <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
References: <git-pr-558-cloudstack@git.apache.org>
In-Reply-To: <git-pr-558-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Vpcr Marvin test and some fixes for
 vprc
Content-Type: text/plain
Message-Id: <20150708083326.76977E03BE@git1-us-west.apache.org>
Date: Wed,  8 Jul 2015 08:33:26 +0000 (UTC)

Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/558#discussion_r34126048
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
    @@ -407,10 +410,10 @@ def fw_vpcrouter(self):
                                 ])
     
             if self.get_type() in ["public"]:
    -            self.fw.append(["nat", "front",
    -                            "-A POSTROUTING -o %s -j SNAT --to-source %s" %
    -                           (self.dev, self.address['public_ip'])
    -                            ])
    +            # self.fw.append(["nat", "front",
    --- End diff --
    
    +1
    
    Can I do all that in the new PR along with the fixes?
    
    I mean... I will have 1 commit removing all the commented out lines. Is it okay?
    
    :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---