Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BA01B18A4E for ; Wed, 1 Jul 2015 07:59:59 +0000 (UTC) Received: (qmail 88589 invoked by uid 500); 1 Jul 2015 07:59:59 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 88535 invoked by uid 500); 1 Jul 2015 07:59:59 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 88524 invoked by uid 99); 1 Jul 2015 07:59:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2015 07:59:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0817CDFBCA; Wed, 1 Jul 2015 07:59:59 +0000 (UTC) From: wilderrodrigues To: dev@cloudstack.apache.org Reply-To: dev@cloudstack.apache.org References: In-Reply-To: Subject: [GitHub] cloudstack pull request: CLOUDSTACK-8597. Failed to migrate volume... Content-Type: text/plain Message-Id: <20150701075959.0817CDFBCA@git1-us-west.apache.org> Date: Wed, 1 Jul 2015 07:59:59 +0000 (UTC) Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/541#issuecomment-117517309 Hi @likitha I understood what the issue says, but what I really meant concerns what the code does. The only practical change in the code was this: if (volume.getHypervisorType() == Hypervisor.HypervisorType.Hyperv || volume.getHypervisorType() == Hypervisor.HypervisorType.VMware) { ... } Which means that now it will also get in the IF when the Hypervisor is of HypervisorType.VMware type. So, what you really want is: support volume migration from zone-wide to cluster-wide storage when hypervisor is VMware. Is that correct? If you look further at the code, when CS will do DELETEVOLUME, it would take into account only VMware. So, HyperV wouldn't be supported. ![image](https://cloud.githubusercontent.com/assets/5129209/8450115/dc04f71c-1fd7-11e5-8cbc-127d4030ce73.png) Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---