Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DDE6818533 for ; Tue, 7 Jul 2015 10:05:09 +0000 (UTC) Received: (qmail 75849 invoked by uid 500); 7 Jul 2015 10:05:09 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 75793 invoked by uid 500); 7 Jul 2015 10:05:09 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 75782 invoked by uid 99); 7 Jul 2015 10:05:09 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jul 2015 10:05:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B04C7D2BA3 for ; Tue, 7 Jul 2015 10:05:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iii8YDRB9r0s for ; Tue, 7 Jul 2015 10:04:58 +0000 (UTC) Received: from emea01-db3-obe.outbound.protection.outlook.com (mail-db3on0111.outbound.protection.outlook.com [157.55.234.111]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id 11F99205B4 for ; Tue, 7 Jul 2015 10:04:57 +0000 (UTC) Received: from DB5PR07MB1159.eurprd07.prod.outlook.com (10.169.32.17) by DB5PR07MB1157.eurprd07.prod.outlook.com (10.169.32.15) with Microsoft SMTP Server (TLS) id 15.1.207.19; Tue, 7 Jul 2015 10:04:32 +0000 Received: from DB5PR07MB1159.eurprd07.prod.outlook.com ([10.169.32.17]) by DB5PR07MB1159.eurprd07.prod.outlook.com ([10.169.32.17]) with mapi id 15.01.0213.000; Tue, 7 Jul 2015 10:04:32 +0000 From: Rohit Yadav To: "dev@cloudstack.apache.org" Subject: Re: resource leaks exception to the 2LGTM rule Thread-Topic: resource leaks exception to the 2LGTM rule Thread-Index: AQHQuJuupShdocF9S0SifV0t8w+//Z3Px2iA Date: Tue, 7 Jul 2015 10:04:32 +0000 Message-ID: <09E3D8ED-0F0F-4F25-983E-D414606DA7AE@shapeblue.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.2102) authentication-results: cloudstack.apache.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [122.161.178.117] x-microsoft-exchange-diagnostics: 1;DB5PR07MB1157;5:d4d0NHAQ3ZqXKug8DRkY3uy9762zjc4Crrdjxnki7sbctDUPCI0ideTDbckvmepX1YJwXbg8OoRi8GdwkBbRFr2hBgFj1/SJZASRljUH7V/tOwSs9RbI+7gGlHJHoks5X3G29CRqHGMGiyi9CCFbRg==;24:sqzL2UnjJYdwtzMCIPp5gm+Y5nnhynvXtJUxoJlDj0Lv/SCEC4Yyii3YQ9jq74DnFWMzdkN3WIJMKbdsKBrFp0a3qz2vR0Rpj9riGIgkmf4=;20:agOQ9bUiPpniNmez+ZzVImnqAakGsgsR+hsHUpAgZpv8o6J/MNDKiCCSm/UU4eBL9/pjGY/x2JheGKSGKfOQcg== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR07MB1157; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DB5PR07MB1157;BCL:0;PCL:0;RULEID:;SRVR:DB5PR07MB1157; x-forefront-prvs: 0630013541 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(377454003)(13734003)(24454002)(83716003)(50226001)(16601075003)(16236675004)(2656002)(106116001)(15395725005)(2950100001)(17760045003)(87936001)(19617315012)(2900100001)(19627595001)(50986999)(450100001)(40100003)(86362001)(99936001)(5001960100002)(18206015028)(77156002)(62966003)(5002640100001)(2501003)(77096005)(2351001)(19580395003)(36756003)(189998001)(82746002)(5890100001)(5001920100001)(46102003)(122556002)(110136002)(107886002)(66066001)(76176999)(19580405001)(102836002)(33656002)(15975445007)(92566002)(57306001)(7099028)(104396002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR07MB1157;H:DB5PR07MB1159.eurprd07.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: multipart/related; boundary="_004_09E3D8ED0F0F4F25983ED414606DA7AEshapebluecom_"; type="multipart/alternative" MIME-Version: 1.0 X-OriginatorOrg: shapeblue.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2015 10:04:32.1132 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fc8906f6-e50e-4dad-98a0-ec2e3abe14f5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR07MB1157 --_004_09E3D8ED0F0F4F25983ED414606DA7AEshapebluecom_ Content-Type: multipart/alternative; boundary="_000_09E3D8ED0F0F4F25983ED414606DA7AEshapebluecom_" --_000_09E3D8ED0F0F4F25983ED414606DA7AEshapebluecom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On 07-Jul-2015, at 3:29 pm, Daan Hoogland > wrote: I want permission to go ahead and address these issues and not create one huge or 73 small PRs. Can I? One huge commit would be fine, testing/merging 73 small PRs is going to be = some work. Regards, Rohit Yadav Software Architect, ShapeBlue [cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A] M. +91 88 262 30892 | rohit.yadav@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build CSForge - rapid IaaS deployment framework CloudStack Consulting CloudStack Software Engineering CloudStack Infrastructure Support CloudStack Bootcamp Training Courses This email and any attachments to it may be confidential and are intended s= olely for the use of the individual to whom it is addressed. Any views or o= pinions expressed are solely those of the author and do not necessarily rep= resent those of Shape Blue Ltd or related companies. If you are not the int= ended recipient of this email, you must neither take any action based upon = its contents, nor copy or show it to anyone. Please contact the sender if y= ou believe you have received this email in error. Shape Blue Ltd is a compa= ny incorporated in England & Wales. ShapeBlue Services India LLP is a compa= ny incorporated in India and is operated under license from Shape Blue Ltd.= Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and= is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a c= ompany registered by The Republic of South Africa and is traded under licen= se from Shape Blue Ltd. ShapeBlue is a registered trademark. --_000_09E3D8ED0F0F4F25983ED414606DA7AEshapebluecom_ Content-Type: text/html; charset="us-ascii" Content-ID: <5B68FF8B0B72D94998BCA6A4E59033C4@eurprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable
On 07-Jul-2015, at 3:29 pm, Daan Hoogl= and <daan.hoogland= @gmail.com> wrote:

I want permission to go ahead and address these issues and not create
one huge or 73 small PRs. Can I?

One huge commit would be fine, testing/merging 73 small PRs is going to be = some work.

Regards,
Rohit Yadav
Software Architect, ShapeBlue




M. +91 88 262 30892 | rohit.yadav@shapeblue.com
Blog: bhaisaab.org | Twitter= : @_bhaisaab





This emai= l and any attachments to it may be confidential and are intended solely for= the use of the individual to whom it is addressed. Any views or opinions e= xpressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related compan= ies. If you are not the intended recipient of this email, you must neither = take any action based upon its contents, nor copy or show it to anyone. Ple= ase contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorpo= rated in England & Wales. ShapeBlue Services India LLP is a company inc= orporated in India and is operated under license from Shape Blue Ltd. Shape= Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. = ShapeBlue SA Pty Ltd is a company registered by The Republic of South Afric= a and is traded under license from Shape Blue Ltd. ShapeBlue is a registere= d trademark.
--_000_09E3D8ED0F0F4F25983ED414606DA7AEshapebluecom_-- --_004_09E3D8ED0F0F4F25983ED414606DA7AEshapebluecom_--