cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Findbugs issues with instance acces to st...
Date Thu, 09 Jul 2015 19:21:11 GMT
GitHub user DaanHoogland opened a pull request:

    https://github.com/apache/cloudstack/pull/573

    Findbugs issues with instance acces to static fields

    I wonder if these fields are used solely on the host or on the management server as well.
    If the code is running on both it is not right that these fields are static as multiple
versions of KVM may be deployed in a cloud. the use of the fields is static so this wrapper
function is needed to negate the findbugs warning.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DaanHoogland/cloudstack findbugs-ST

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #573
    
----
commit 187c5c7817532eb6764a4147cf6bea4e3db98d8b
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-07-09T18:48:49Z

    adhere to naming conventions for enums

commit cb4618673d193ef9492c5e5a9f57a9c37fb390be
Author: Daan Hoogland <daan@onecht.net>
Date:   2015-07-09T19:05:10Z

    findbugs: create wrapper to deal with static field

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message