cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From isoutham <>
Subject [GitHub] cloudstack pull request: Vpcr Marvin test and some fixes for vprc
Date Thu, 02 Jul 2015 14:12:34 GMT
GitHub user isoutham opened a pull request:

    Vpcr Marvin test and some fixes for vprc

    A combined commit because otherwise it would not make sense.
    If I commit the fixes alone there is not test to verify them
    If I commit the tests alone it will not work because it found bugs
    So both together
    1.  Fix incorrect SNAT configuration (was adding SNAT to interfaces not marked as nat
in the json config). 
    2.  Fix interface used for keepalived multicast traffic to be lowest guest i/f.  This
stops some unnecessary keepalived flip-flops
    3.  If all nat rules are removed and re-added public interfaces would stay down (because
master status does not change and CS deletes the interface)
    4.  Small change to Marvin to allow a test to change the retries count (is downwardly
    5.  A couple of pep8 things.
    6.  Improved locking during master/backup transitions.
    The test still very occasionally fails with a (correct) double master detection.  When
I have worked out why, I will produce another PR.  It appears to be a timing issue and could
be tricky to find.

You can merge this pull request into a Git repository by running:

    $ git pull vpcr_test_andfixes

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
commit b2cf51caf3d36f1f85090ebfe1e5219b5e17f9a9
Author: Ian Southam <>
Date:   2015-07-02T12:15:20Z

    New test and fixes for vpcr code in 4.6

commit 6989a17a5e214a8ef9b2fbcbb6269e507be29b48
Author: Ian Southam <>
Date:   2015-07-02T12:19:15Z

    Fixes to enable test to succeed.  Small change to Marvin to be able to override retries

commit 73e654e3eb434204377d8adaf706dd93ccfc23db
Author: Ian Southam <>
Date:   2015-07-02T13:19:48Z

    Forgot to activate teardown


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message