cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Angus <paul.an...@shapeblue.com>
Subject RE: [PROPOSAL] Commit to master through PR only
Date Mon, 13 Jul 2015 06:50:02 GMT
I agree with Daan,

Lazy consensus QA is not going to improve code quality. If anything we're highlighting a structural
issue with the amount of resource available to review these PRs - which is a different issue
and would need looking at as such as it is fundamental to our push for improved quality.


Regards

Paul Angus
VP Technology/Cloud Architect
S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus
paul.angus@shapeblue.com

-----Original Message-----
From: Daan Hoogland [mailto:daan.hoogland@gmail.com]
Sent: Thursday, July 9, 2015 11:25 AM
To: dev
Subject: Re: [PROPOSAL] Commit to master through PR only

On Thu, Jul 9, 2015 at 12:04 PM, Rohit Yadav <rohit.yadav@shapeblue.com>
wrote:

>
> On 09-Jul-2015, at 2:56 pm, Daan Hoogland <daan.hoogland@gmail.com> wrote:
>
> I like the idea but think that 72 hours is way to short
>
>
>  I think 72 hours (note: no counting weekends) should be good enough,
> which is the window for our release/vote process as well. We can
> increase this to perhaps 120 hours (5 days, except weekends).
>
​7 days (including weekends even seem short to me. The objective is to make shore all code
is reviewed!​



> Doing this would allow at the committers to get their work merged
> without waiting on others. If the PR has one commit (or squashed into
> one commit), it would be easier to revert their merged PR if a future issue is found.
>
​The idea is that committers do wait on others. Reviews are required for a reason. A merge
commit can easily be reverted as well. Not related to this discussion.
​

> and also a
> committers must have shown effort to attract attention to their PR by
> more then the old 'mail​-and-forget' management method.
>
>
>  Given that committers/pmc-members are recognised as a contributors
> working in their free time, it will be challenging to enforce
> committers/pmc-members to participate in PR reviews.
>
​No one is expected to work in their free time. I know a lot of us do but I would say we
do most work in sponsored time.

--
Daan
Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/>
CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/>

This email and any attachments to it may be confidential and are intended solely for the use
of the individual to whom it is addressed. Any views or opinions expressed are solely those
of the author and do not necessarily represent those of Shape Blue Ltd or related companies.
If you are not the intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender if you believe
you have received this email in error. Shape Blue Ltd is a company incorporated in England
& Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated
under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated
in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company
registered by The Republic of South Africa and is traded under license from Shape Blue Ltd.
ShapeBlue is a registered trademark.
Mime
View raw message