cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [PROPOSAL] Commit to master through PR only
Date Thu, 09 Jul 2015 10:25:27 GMT
On Thu, Jul 9, 2015 at 12:04 PM, Rohit Yadav <rohit.yadav@shapeblue.com>
wrote:

>
> On 09-Jul-2015, at 2:56 pm, Daan Hoogland <daan.hoogland@gmail.com> wrote:
>
> I like the idea but think that 72 hours is way to short
>
>
>  I think 72 hours (note: no counting weekends) should be good enough,
> which is the window for our release/vote process as well. We can increase
> this to perhaps 120 hours (5 days, except weekends).
>
​7 days (including weekends even seem short to me. The objective is to make
shore all code is reviewed!​



> Doing this would allow at the committers to get their work merged without
> waiting on others. If the PR has one commit (or squashed into one commit),
> it would be easier to revert their merged PR if a future issue is found.
>
​The idea is that committers do wait on others. Reviews are required for a
reason. A merge commit can easily be reverted as well. Not related to this
discussion.
​

> and also a
> committers must have shown effort to attract attention to their PR by more
> then the old 'mail​-and-forget' management method.
>
>
>  Given that committers/pmc-members are recognised as a contributors
> working in their free time, it will be challenging to enforce
> committers/pmc-members to participate in PR reviews.
>
​No one is expected to work in their free time. I know a lot of us do but I
would say we do most work in sponsored time.

-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message