cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)
Date Wed, 08 Jul 2015 11:48:41 GMT
That was never formalized, hence I put it as a shakespearian question.
I did sugest it otherwise I would have just reverted. I don't like the
exception but if the number of people working on integration is to low
to have a good flow we could.

On Wed, Jul 8, 2015 at 1:46 PM, Sanjeev N <sanjeev@apache.org> wrote:
> I thought there is a limitation on LGTMs for integration tests?
>
> On Wed, Jul 8, 2015 at 5:11 PM, Daan Hoogland <daan.hoogland@gmail.com>
> wrote:
>
>> guys and dolss,
>>
>> this was closed with only 1 LGTM! we agreed not to submit with less
>> then two ok reviews on master. So next steps? revert? some extra
>> justification or else revert? .....
>>
>> On Wed, Jul 8, 2015 at 12:39 PM, asfgit <git@git.apache.org> wrote:
>> > Github user asfgit closed the pull request at:
>> >
>> >     https://github.com/apache/cloudstack/pull/567
>> >
>> >
>> > ---
>> > If your project is set up for it, you can reply to this email and have
>> your
>> > reply appear on GitHub as well. If your project does not have this
>> feature
>> > enabled and wishes so, or if the feature is enabled but not working,
>> please
>> > contact infrastructure at infrastructure@apache.org or file a JIRA
>> ticket
>> > with INFRA.
>> > ---
>>
>>
>>
>> --
>> Daan
>>



-- 
Daan

Mime
View raw message