cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [GitHub] cloudstack pull request: dhcp/dns offload feature config dirve cha...
Date Fri, 10 Jul 2015 13:54:14 GMT
my bad, I would like to see "$LGTM" (as in on the start of a line),
though. This looks like a comment at first.

On Fri, Jul 10, 2015 at 3:42 PM, sateesh-chodapuneedi
<git@git.apache.org> wrote:
> Github user sateesh-chodapuneedi commented on the pull request:
>
>     https://github.com/apache/cloudstack/pull/568#issuecomment-120414615
>
>     @DaanHoogland
>
>     I think there are 2 LGTM on this one - from @sanju1010 & @kishankavala
>
>     > sanju1010 added a note a day ago
>     > Need to comment this if DHCP Server is available in the shared network broadcast
domain while >running tests. Looks good to me.
>
>     >kishankavala commented a day ago
>     >Looks good to me.
>     >Commented on older PR earlier.
>     >PR #552 can be removed
>
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---



-- 
Daan

Mime
View raw message