cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [PROPOSAL] Commit to master through PR only
Date Thu, 09 Jul 2015 09:26:42 GMT
On Thu, Jul 9, 2015 at 10:51 AM, Rohit Yadav <rohit.yadav@shapeblue.com>
wrote:

>
> On 09-Jul-2015, at 2:14 pm, Rohit Yadav <rohit.yadav@shapeblue.com> wrote:
>
> - This seems to be already failing, under the Apache way IMO there is no
> way we can enforce and ensure that at least two people would review any and
> every PR. There are already a growing number of open PRs that we cannot
> close unless we get 2 LGTM. Should we put some sort of maximum wait time on
> PRs that attract no attention (review or discussions), say of 72 hours
> (excluding weekends) so at least committers can merge their changes?
>
>
>  Forgot to explicitly add in the suggestion above - Such attention-deficit
> PRs (no review, discussion or comment of any sorts) should only be merged
> if Travis is green along with other automated jenkins jobs (rat, build etc)
> we’ve setup.
>
​I like the idea but think that 72 hours is way to short and also a
committers must have shown effort to attract attention to their PR by more
then the old 'mail​-and-forget' management method.


>
>
> Regards,
> Rohit Yadav
>


-- 
Daan

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message