cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjeev N <sanj...@apache.org>
Subject Re: [GitHub] cloudstack pull request: Newb
Date Tue, 14 Jul 2015 07:08:25 GMT
LGTM!!

On Tue, Jul 14, 2015 at 11:47 AM, pavanb018 <git@git.apache.org> wrote:

> GitHub user pavanb018 opened a pull request:
>
>     https://github.com/apache/cloudstack/pull/581
>
>     Newb
>
>     Test Create/Delete a LB rule and verify correct usage is recorded ...
> === TestName: test_01_lb_usage | Status : SUCCESS ===
>     ok
>
>     ----------------------------------------------------------------------
>     Ran 1 test in 50.564s
>
>     OK
>
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/pavanb018/cloudstack newb
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/cloudstack/pull/581.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #581
>
> ----
> commit 6f91392e9c037d542d0150cbf1d12501e9d9ba45
> Author: pavan018 <pavanbandarupally@gmail.com>
> Date:   2015-07-13T12:41:24Z
>
>     Passing firewal service parameter for LB rule creation
>
> commit df7646af01828cb9ea471e8efcfff9e5d4156437
> Author: pavan018 <pavanbandarupally@gmail.com>
> Date:   2015-07-14T06:14:04Z
>
>     Firewall service parameter addition typos
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message