cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjeev N <sanj...@apache.org>
Subject Re: [GitHub] cloudstack pull request: CLOUDSTACK-8636: Verify failure of creati...
Date Wed, 15 Jul 2015 08:46:35 GMT
LGTM

On Wed, Jul 15, 2015 at 2:04 PM, pritisarap12 <git@git.apache.org> wrote:

> Github user pritisarap12 commented on a diff in the pull request:
>
>     https://github.com/apache/cloudstack/pull/592#discussion_r34656988
>
>     --- Diff: test/integration/testpaths/testpath_custom_disk_offering.py
> ---
>     @@ -0,0 +1,84 @@
>     +# Licensed to the Apache Software Foundation (ASF) under one
>     +# or more contributor license agreements.  See the NOTICE file
>     +# distributed with this work for additional information
>     +# regarding copyright ownership.  The ASF licenses this file
>     +# to you under the Apache License, Version 2.0 (the
>     +# "License"); you may not use this file except in compliance
>     +# with the License.  You may obtain a copy of the License at
>     +#
>     +#   http://www.apache.org/licenses/LICENSE-2.0
>     +#
>     +# Unless required by applicable law or agreed to in writing,
>     +# software distributed under the License is distributed on an
>     +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
>     +# KIND, either express or implied.  See the License for the
>     +# specific language governing permissions and limitations
>     +# under the License.
>     +""" Test case for Create Custom DiskOffering with size Test Path
>     +"""
>     +
>     +from nose.plugins.attrib import attr
>     +from marvin.cloudstackTestCase import cloudstackTestCase
>     +from marvin.cloudstackAPI import (createDiskOffering)
>     +from marvin.lib.utils import (cleanup_resources)
>     +from marvin.lib.common import (get_domain,
>     +                               get_zone
>     +                               )
>     +
>     +
>     +class TestCustomDiskOfferingWithSize(cloudstackTestCase):
>     +
>     +    @classmethod
>     +    def setUpClass(cls):
>     +        testClient = super(
>     +            TestCustomDiskOfferingWithSize,
>     +            cls).getClsTestClient()
>     +        cls.apiclient = testClient.getApiClient()
>     +        cls.testdata = testClient.getParsedTestDataConfig()
>     +        cls.hypervisor = cls.testClient.getHypervisorInfo()
>     +
>     +        # Get Zone, Domain and templates
>     +        cls.domain = get_domain(cls.apiclient)
>     +        cls.zone = get_zone(cls.apiclient,
> testClient.getZoneForTests())
>     +        cls._cleanup = []
>     +
>     +        cls.tearDownClass()
>     +
>     +        return
>     +
>     +    @classmethod
>     +    def tearDownClass(cls):
>     +        try:
>     +            cleanup_resources(cls.apiclient, cls._cleanup)
>     +        except Exception as e:
>     +            raise Exception("Warning: Exception during cleanup : %s"
> % e)
>     +
>     +    def setUp(self):
>     +        self.apiclient = self.testClient.getApiClient()
>     +        self.dbclient = self.testClient.getDbConnection()
>     +        self.cleanup = []
>     +
>     +    def tearDown(self):
>     +        try:
>     +            cleanup_resources(self.apiclient, self.cleanup)
>     +        except Exception as e:
>     +            raise Exception("Warning: Exception during cleanup : %s"
> % e)
>     +        return
>     +
>     +    @attr(tags=["basic", "advanced"], required_hardware="false")
>     +    def test_create_custom_disk_offering_with_size(self):
>     +        """ Create custom disk offerign with size
>     +            1.   Create custom disk offering with size.
>     +            2.   Should not allow to create custom disk offering
>     +                 with size mentioned.(Exception should be raised)
>     +        """
>     +
>     +        with self.assertRaises(Exception):
>     --- End diff --
>
>     Updated the testcase as per review changes.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message