cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebgoa <run...@gmail.com>
Subject Re: resource leaks exception to the 2LGTM rule
Date Tue, 07 Jul 2015 10:15:31 GMT

On Jul 7, 2015, at 12:10 PM, Daan Hoogland <daan.hoogland@gmail.com> wrote:

> I will not do it in one commit, if we insist on a PR i will do 73 commits
> in one PR.
> 

are you automating those commits ?

I would not mind scanning through them and giving green light. and in that case squash might
be good :)

> On Tue, Jul 7, 2015 at 12:04 PM, Rohit Yadav <rohit.yadav@shapeblue.com>
> wrote:
> 
>> 
>> On 07-Jul-2015, at 3:29 pm, Daan Hoogland <daan.hoogland@gmail.com> wrote:
>> 
>> I want permission to go ahead and address these issues and not create
>> one huge or 73 small PRs. Can I?
>> 
>> 
>> One huge commit would be fine, testing/merging 73 small PRs is going to
>> be some work.
>> 
>> Regards,
>> Rohit Yadav
>> Software Architect, ShapeBlue
>> 
>> 
>> 
>> 
>> M. +91 88 262 30892 | rohit.yadav@shapeblue.com
>> Blog: bhaisaab.org | Twitter: @_bhaisaab
>> 
>> 
>> 
>> 
>> Find out more about ShapeBlue and our range of CloudStack related services
>> 
>> IaaS Cloud Design & Build
>> <http://shapeblue.com/iaas-cloud-design-and-build//>
>> CSForge – rapid IaaS deployment framework <http://shapeblue.com/csforge/>
>> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/>
>> CloudStack Software Engineering
>> <http://shapeblue.com/cloudstack-software-engineering/>
>> CloudStack Infrastructure Support
>> <http://shapeblue.com/cloudstack-infrastructure-support/>
>> CloudStack Bootcamp Training Courses
>> <http://shapeblue.com/cloudstack-training/>
>> 
>> This email and any attachments to it may be confidential and are intended
>> solely for the use of the individual to whom it is addressed. Any views or
>> opinions expressed are solely those of the author and do not necessarily
>> represent those of Shape Blue Ltd or related companies. If you are not the
>> intended recipient of this email, you must neither take any action based
>> upon its contents, nor copy or show it to anyone. Please contact the sender
>> if you believe you have received this email in error. Shape Blue Ltd is a
>> company incorporated in England & Wales. ShapeBlue Services India LLP is a
>> company incorporated in India and is operated under license from Shape Blue
>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil
>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is
>> a company registered by The Republic of South Africa and is traded under
>> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>> 
> 
> 
> 
> -- 
> Daan


Mime
View raw message