cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rohit Yadav <>
Subject Re: [DISCUSS] PR list length
Date Tue, 14 Jul 2015 12:02:20 GMT

On 14-Jul-2015, at 5:26 pm, Daan Hoogland <<>>


It is a concern to me that the list of PRs on our github page is
beyond a single page (maybe configurable but now a t a very reasonable
25). I think we should adhere to a discipline of not having any PRs
open after the weekend. This is putting a very strong statement
outthere, I realize. A PR might be under heavy construction and very
big (which should result in a discussion about splitting it!) I
Discussed this with Wilder and the idea popped up to have a seven day
limit on (undicussed) PRs. This is however more sensible from an
automation point of view then from a development discipline point of
view. A regular cycle of closing-or-discarding PRs makes more sense.
The list of PRs remaining open is slowly but very steadily growing
over time.


Sounds good, 1 week+ open PR which has green checks (rat, jenkins build, travis), no objections
from anybody (and perhaps with at least one LGTM) should be merged on master.

Rohit Yadav
Software Architect, ShapeBlue


M. +91 88 262 30892 |<>
Blog:<> | Twitter: @_bhaisaab

Find out more about ShapeBlue and our range of CloudStack related services

IaaS Cloud Design & Build<>
CSForge - rapid IaaS deployment framework<>
CloudStack Consulting<>
CloudStack Software Engineering<>
CloudStack Infrastructure Support<>
CloudStack Bootcamp Training Courses<>

This email and any attachments to it may be confidential and are intended solely for the use
of the individual to whom it is addressed. Any views or opinions expressed are solely those
of the author and do not necessarily represent those of Shape Blue Ltd or related companies.
If you are not the intended recipient of this email, you must neither take any action based
upon its contents, nor copy or show it to anyone. Please contact the sender if you believe
you have received this email in error. Shape Blue Ltd is a company incorporated in England
& Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated
under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated
in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company
registered by The Republic of South Africa and is traded under license from Shape Blue Ltd.
ShapeBlue is a registered trademark.

  • Unnamed multipart/related (inline, None, 0 bytes)
View raw message