cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scan-ad...@coverity.com
Subject New Defects reported by Coverity Scan for cloudstack
Date Mon, 20 Jul 2015 12:45:24 GMT

Hi,

Please find the latest report on new defect(s) introduced to cloudstack found with Coverity
Scan.

2 new defect(s) introduced to cloudstack found with Coverity Scan.
11 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed
by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1312009:  FindBugs: Dodgy code  (FB.REC_CATCH_EXCEPTION)
/server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java: 938 in com.cloud.consoleproxy.ConsoleProxyManagerImpl.allocCapacity(long)()


________________________________________________________________________________________________________
*** CID 1312009:  FindBugs: Dodgy code  (FB.REC_CATCH_EXCEPTION)
/server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java: 938 in com.cloud.consoleproxy.ConsoleProxyManagerImpl.allocCapacity(long)()
932     
933                         if (consoleProxyVmFromStoppedPool) {
934                             destroyProxy(proxyVmId);
935                         }
936                     }
937                 }
>>>     CID 1312009:  FindBugs: Dodgy code  (FB.REC_CATCH_EXCEPTION)
>>>     Catching RuntimeExceptions, perhaps unintentionally, with a catch block for
Exception
938             } catch (Exception e) {
939                errorString = e.getMessage();
940                throw e;
941             } finally {
942                 // TODO - For now put all the alerts as creation failure. Distinguish
between creation vs start failure in future.
943                 // Also add failure reason since startvm masks some of them.

** CID 1312010:  FindBugs: Dodgy code  (FB.DLS_DEAD_LOCAL_STORE)
/engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java:
230 in org.apache.cloudstack.storage.cache.manager.StorageCacheManagerImpl.createCacheObject(org.apache.cloudstack.engine.subsystem.api.storage.DataObject,
org.apache.cloudstack.engine.subsystem.api.storage.DataStore)()


________________________________________________________________________________________________________
*** CID 1312010:  FindBugs: Dodgy code  (FB.DLS_DEAD_LOCAL_STORE)
/engine/storage/cache/src/org/apache/cloudstack/storage/cache/manager/StorageCacheManagerImpl.java:
230 in org.apache.cloudstack.storage.cache.manager.StorageCacheManagerImpl.createCacheObject(org.apache.cloudstack.engine.subsystem.api.storage.DataObject,
org.apache.cloudstack.engine.subsystem.api.storage.DataStore)()
224         @Override
225         public DataObject createCacheObject(DataObject data, DataStore store) {
226             DataObject objOnCacheStore = null;
227             final Object lock;
228             final DataObjectType type = data.getType();
229             final String typeName;
>>>     CID 1312010:  FindBugs: Dodgy code  (FB.DLS_DEAD_LOCAL_STORE)
>>>     Dead store to role
230             final DataStoreRole role = store.getRole();
231             final long storeId = store.getId();
232             final long dataId = data.getId();
233     
234             /*
235              * Make sure any thread knows own lock type.


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/943?tab=overview

To manage Coverity Scan email notifications for "dev@cloudstack.apache.org", click https://scan.coverity.com/subscriptions/edit?email=dev%40cloudstack.apache.org&token=494aabd5ba647999fa41b6d766646231


Mime
View raw message