cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sebastien Goasguen <run...@gmail.com>
Subject Re: revert or not revert? (was: [GitHub] cloudstack pull request: CLOUDSTACK-8583 : fixing issue related to...)
Date Thu, 09 Jul 2015 14:21:39 GMT

> On Jul 9, 2015, at 3:27 PM, David Nalley <david@gnsa.us> wrote:
> 
> On Thu, Jul 9, 2015 at 4:49 AM, Rohit Yadav <rohit.yadav@shapeblue.com>
> wrote:
> 
>> 
>> On 09-Jul-2015, at 12:50 pm, Sebastien Goasguen <runseb@gmail.com> wrote:
>> 
>> Let’s revert , that’s our new rule
>> 
>> 
>> Since we have not voted what/how we are going to do commits, let’s treat
>> this more of a guideline or honour code.
>> 
> 
> 
> Votes aren't strictly necessary. As a matter of fact, votes should be
> avoided if at all possible. We should strive for consensus, and when we
> have it, it is as binding as if we had a tally of votes.
> 
> 
>> 
>> I’ve expressed few concersn on this rule wrt code reviewing for PRs that
>> are not getting attention, so IMO let’s try to have the discussion and find
>> solution before we really start enforcing them.
>> 
>> 
> So my take (FWIW) is that without the pain, we'll never adjust our method
> of operation or find the solutions. In example, no one came to the list
> asking for reviews.
> 

+1


> --David


Mime
View raw message