cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cloudstack 8656 adding messages to empty ...
Date Thu, 30 Jul 2015 06:28:19 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/637#issuecomment-126200897
  
    Hi @DaanHoogland 
    
    Nice you took time to have a look at those. It really helps sys admins to know what is
going on with ACS. However, I would rather have them logged as WARN over INFO. Why? Because
if we fall into the catch block, is because something went wrong or might probably require
manual intervention. If you agree, would that be a lot of work to change them into WARN?
    
    Concerning the logs getting filled up too soon, I wouldn't really bother. From my point
of view that's an admin task to have a clever rotation of logs. If ACS code base was more
robust, we could afford less logs and filling up files wouldn't be a problem. But since it
isn't, let's make sure the users/admins are aware about what is happening.
    
    With respect to the InterruptedExceptions, we can log them as debug, but ignoring them
completely wouldn't be nice. 
    
    Cheers,
    Wilder  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message