cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsafonseca <...@git.apache.org>
Subject [GitHub] cloudstack pull request: fix systemvm64template build, fix .deb pa...
Date Tue, 28 Jul 2015 12:08:36 GMT
Github user rsafonseca commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/626#discussion_r35639533
  
    --- Diff: debian/rules ---
    @@ -1,6 +1,6 @@
     #!/usr/bin/make -f
     # -*- makefile -*-
    -VERSION := $(shell mvn org.apache.maven.plugins:maven-help-plugin:2.1.1:evaluate -Dexpression=project.version
| grep -v "\[")
    +VERSION := $(shell cat pom.xml |sed '22!d'| cut -d'>' -f2 |cut -d'<' -f1)
    --- End diff --
    
    I made a separate PR for 4.4 and master. 4.4 got merged and master didn't.. you can check
the PR here:
    
    https://github.com/apache/cloudstack/pull/341
    
    It wasn't merged mostly due to aesthetic reasons, although using native tools instead
of maven would provide a faster run and should have less compatibility issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message