cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kansal <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Dereference NULL return value
Date Mon, 27 Jul 2015 11:02:47 GMT
Github user kansal commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/618#discussion_r35524999
  
    --- Diff: plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
    @@ -358,7 +363,8 @@ private boolean setup() {
             }
             _timer = new Timer();
             final HttpClient client = new HttpClient();
    -        final String idpMetaDataUrl = SAMLIdentityProviderMetadataURL.value();
    +        //final String idpMetaDataUrl = SAMLIdentityProviderMetadataURL.value();
    --- End diff --
    
    @bhaisaab  Sure. Removing the comment. The function call is needed for mocking at the
time of unit testing. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message