cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From karuturi <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...
Date Thu, 23 Jul 2015 06:24:30 GMT
Github user karuturi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/609#discussion_r35292915
  
    --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
    @@ -57,17 +57,22 @@
         private LdapContextFactory _ldapContextFactory;
     
         @Inject
    -    private LdapUserManager _ldapUserManager;
    +    private LdapConfiguration _ldapConfiguration;
    +
    +    @Inject LdapUserManagerFactory _ldapUserManagerFactory;
    +
     
         public LdapManagerImpl() {
             super();
         }
     
    -    public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory
ldapContextFactory, final LdapUserManager ldapUserManager) {
    +    public LdapManagerImpl(final LdapConfigurationDao ldapConfigurationDao, final LdapContextFactory
ldapContextFactory, final LdapUserManagerFactory ldapUserManagerFactory,
    --- End diff --
    
    this is not added now. its an existing one which is modified. I am planning on removing
them in the future commits as there are other ways to inject them to tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message