cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kishankavala <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Dereference NULL return value
Date Thu, 23 Jul 2015 05:15:11 GMT
Github user kishankavala commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/618#discussion_r35290636
  
    --- Diff: plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
    @@ -368,8 +368,14 @@ private boolean setup() {
                     _idpMetaDataProvider = new HTTPMetadataProvider(_timer, client, idpMetaDataUrl);
                 } else {
                     File metadataFile = PropertiesUtil.findConfigFile(idpMetaDataUrl);
    -                s_logger.debug("Provided Metadata is not a URL, trying to read metadata
file from local path: " + metadataFile.getAbsolutePath());
    -                _idpMetaDataProvider = new FilesystemMetadataProvider(_timer, metadataFile);
    +                if (metadataFile == null) {
    +                    s_logger.error("Metadata file returned null");
    --- End diff --
    
    Can you please update the error message: "Provided Metadata is not a URL, Unable to locate
metadata file from local path"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message