cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...
Date Wed, 22 Jul 2015 21:06:28 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/615#issuecomment-123863689
  
    Hi Lennert,
    
    The Command claases use annotations for the fields. The fields values are set via reflection.
I bet my iPhone the decoding is being done there :)
    
    I will have a look tomorrow, as I might know where the whole thing is happening.
    
    For now I would say LGTM and please merge it.
    
    Cheers,
    Wilder
    
    Sent from my iPhone
    
    On 22 Jul 2015, at 20:29, Lennert den Teuling <notifications@github.com<mailto:notifications@github.com>>
wrote:
    
    
    @wilderrodrigues<https://github.com/wilderrodrigues> reproducing is really easy,
just try to register your public key using the registerSSHKeyPair API call. In the database
you will find you key, but only a part of it. You can try this on 4.5 but as far we know the
master contains this same issue. We did not test 4.4.
    
    @borisroman<https://github.com/borisroman> has been looking where the key gets decoded
first, but wasn't able to yet. If you can help, that would be great.
    
    —
    Reply to this email directly or view it on GitHub<https://github.com/apache/cloudstack/pull/615#issuecomment-123818145>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message