cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8596 ability to query nested g...
Date Wed, 22 Jul 2015 05:05:46 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/609#discussion_r35181750
  
    --- Diff: plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
    @@ -43,14 +45,14 @@
         private ConfigurationDao _configDao;
     
         @Inject
    -    private LdapManager _ldapManager;
    +    private LdapConfigurationDao _ldapConfigurationDao;
     
         public LdapConfiguration() {
         }
     
    -    public LdapConfiguration(final ConfigurationDao configDao, final LdapManager ldapManager)
{
    +    public LdapConfiguration(final ConfigurationDao configDao, final LdapConfigurationDao
ldapConfigurationDao) {
             _configDao = configDao;
    -        _ldapManager = ldapManager;
    +        _ldapConfigurationDao = ldapConfigurationDao;
    --- End diff --
    
    Why inject and pass on in the constructor. Do both have usage scenarios?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message