cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8605: KVM: Config Drive and ge...
Date Fri, 17 Jul 2015 11:06:12 GMT
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/577#issuecomment-122247318
  
    Code-wise I'm not to happy. There are all kinds of assumptions about paths. mkisofs for
example always being there in /usr/bin.
    
    Using /tmp for temporary directories, who says that /tmp is big enough on every system?
Always using /var/lib/libvirt to place the ISO? Why not fetch the local storage pool and figure
out what the path is.
    
    It's not guaranteerd that it will be /var/lib/libvirt/images on all systems.
    
    Imho there are to many assumptions in the code which makes it fragile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message