cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Date Fri, 17 Jul 2015 07:55:43 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/600#discussion_r34869004
  
    --- Diff: framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
---
    @@ -108,7 +107,7 @@ public void scan() {
                     while (resources.hasMoreElements()) {
                         String filePath = resources.nextElement().getFile();
                         // WINDOWS HACK
    -                    if (filePath.indexOf("%20") > 0)
    +                    if (filePath != null && filePath.indexOf("%20") > 0)
    --- End diff --
    
    I didn't do that as there is a new assignment to the var in the if block. The replaceAll
contract doesn't state a null retrun as possibiliy so I'll move the replaceAll inside the
next if block if the rest of the flow allows it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message