cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From koushik-das <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Coverity issues in OmniwireClassRegistry
Date Fri, 17 Jul 2015 07:33:59 GMT
Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/600#discussion_r34867930
  
    --- Diff: framework/ipc/src/org/apache/cloudstack/framework/serializer/OnwireClassRegistry.java
---
    @@ -108,7 +107,7 @@ public void scan() {
                     while (resources.hasMoreElements()) {
                         String filePath = resources.nextElement().getFile();
                         // WINDOWS HACK
    -                    if (filePath.indexOf("%20") > 0)
    +                    if (filePath != null && filePath.indexOf("%20") > 0)
    --- End diff --
    
    There is already a filePath != null immediately below. The check can go inside that to
avoid duplication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message