cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wido <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8581: S3, make connection TTL ...
Date Thu, 16 Jul 2015 13:27:34 GMT
Github user wido commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/582#discussion_r34786110
  
    --- Diff: api/src/com/cloud/agent/api/to/S3TO.java ---
    @@ -118,6 +122,14 @@ public boolean equals(final Object thatObject) {
                 return false;
             }
     
    +        if (connectionTtl != null ? !connectionTtl.equals(thatS3TO.connectionTtl) : thatS3TO.connectionTtl
!= null) {
    +            return false;
    --- End diff --
    
    I agree, but the other lines there also have the very complex if-else statements.
    
    I want to write the S3 code anyway, it's buggy as hell


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message