cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8608. System VM's failed to st...
Date Thu, 16 Jul 2015 11:25:13 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/555#discussion_r34777747
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
---
    @@ -697,6 +699,22 @@ private String setupMountPoint(String parent) {
             return mountPoint;
         }
     
    +    @Override
    +    public synchronized void setSystemVmTmpltPermission(String mountPoint) {
    +        if (!s_isSystemVmTmpltPermissionSet) {
    +            s_logger.debug("Set permissions for " + mountPoint);
    +            String result = null;
    +            Script script = new Script(true, "chmod", _timeout, s_logger);
    +            script.add("-R", "0777", mountPoint);
    +            result = script.execute();
    +            if (result != null) {
    +                s_logger.warn("Unable to set permissions for " + mountPoint + " due to
" + result);
    +            } else {
    +                s_isSystemVmTmpltPermissionSet = true;
    +            }
    --- End diff --
    
    instance write-access to a static, even when in a synchronised block of code does not
make for a good pattern. There is no guarantee that some other (synchronised) block accesses
it as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message