cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8628: kvm: Disable Fencing whe...
Date Thu, 16 Jul 2015 04:50:59 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/580#discussion_r34755639
  
    --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtFenceCommandWrapper.java
---
    @@ -48,6 +48,18 @@ public Answer execute(final FenceCommand command, final LibvirtComputingResource
             final KVMHAMonitor monitor = libvirtComputingResource.getMonitor();
     
             final List<NfsStoragePool> pools = monitor.getStoragePools();
    +
    +        /**
    +         * We can only safely fence off hosts when we use NFS
    +         * On NFS primary storage pools hosts continuesly write
    +         * a heartbeat. Disable Fencing Off for hosts without NFS
    +         */
    +        if (pools.size() == 0) {
    +            String logline = "No NFS storage pools found. No way to safely fence " +
command.getVmName() + " on host " + command.getHostGuid();
    --- End diff --
    
    maybe add an alert for admin here, _alertMgr.sendAlert?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message