cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pritisarap12 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8632: Unable to revert snapsho...
Date Wed, 15 Jul 2015 08:45:04 GMT
Github user pritisarap12 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/590#discussion_r34657738
  
    --- Diff: test/integration/testpaths/testpath_revert_snap.py ---
    @@ -0,0 +1,159 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +""" Test cases for Verifying revert snapshot 
    +"""
    +from nose.plugins.attrib import attr
    +from marvin.cloudstackTestCase import cloudstackTestCase
    +from marvin.lib.utils import (cleanup_resources,
    +                             validateList)
    +from marvin.lib.base import (Account,
    +                             ServiceOffering,
    +                             Snapshot,
    +                             VmSnapshot,
    +                             VirtualMachine,
    +                             )
    +from marvin.lib.common import (get_domain,
    +                               get_zone,
    +                               get_template,
    +                               list_volumes,
    +                              )
    +
    +class TestUnableToRevertSnapshot(cloudstackTestCase):
    +
    +    @classmethod
    +    def setUpClass(cls):
    +        testClient = super(TestUnableToRevertSnapshot, cls).getClsTestClient()
    +        cls.apiclient = testClient.getApiClient()
    +        cls.testdata = testClient.getParsedTestDataConfig()
    +
    +        cls.hypervisor = cls.testClient.getHypervisorInfo()
    +        # Get Zone, Domain and templates
    +        cls.domain = get_domain(cls.apiclient)
    +        cls.zone = get_zone(cls.apiclient, testClient.getZoneForTests())
    +
    +        cls.template = get_template(
    +            cls.apiclient,
    +            cls.zone.id,
    +            cls.testdata["ostype"])
    +
    +        cls._cleanup = []
    +
    +        try:
    +
    +            cls.skiptest = False
    +
    +            if cls.hypervisor.lower() not in ['xenserver']:
    +                cls.skiptest = True
    +                return     
    +            # Create an account
    +            cls.account = Account.create(
    +                cls.apiclient,
    +                cls.testdata["account"],
    +                domainid=cls.domain.id
    +            )
    +
    +            # Create user api client of the account
    +            cls.userapiclient = testClient.getUserApiClient(
    +                UserName=cls.account.name,
    +                DomainName=cls.account.domain
    +            )
    +            # Create Service offering
    +            cls.service_offering = ServiceOffering.create(
    +                cls.apiclient,
    +                cls.testdata["service_offering"],
    +            )
    +
    +            cls._cleanup = [
    +                cls.account,
    +                cls.service_offering,
    +            ]
    +        except Exception as e:
    +            cls.tearDownClass()
    +            raise e
    +        return
    +
    +    @classmethod
    +    def tearDownClass(cls):
    +        try:
    +            cleanup_resources(cls.apiclient, cls._cleanup)
    +        except Exception as e:
    +            raise Exception("Warning: Exception during cleanup : %s" % e)
    +
    +    def setUp(self):
    +        self.apiclient = self.testClient.getApiClient()
    +        self.dbclient = self.testClient.getDbConnection()
    +        self.cleanup = []
    +        if self.skiptest:
    +            self.skipTest("This test is to be checked on xenserver only  Hence, skip
for %s"  % self.hypervisor)
    +
    +    def tearDown(self):
    +        try:
    +            cleanup_resources(self.apiclient, self.cleanup)
    +        except Exception as e:
    +            raise Exception("Warning: Exception during cleanup : %s" % e)
    +        return
    +
    +    @attr(tags=["advanced", "basic"])
    +    def test_01_check_revert_snapshot(self):
    +        """ Test revert snapshot on XenServer
    +
    +        # 1. Deploy a VM.
    +        # 2. Take VM snapshot.
    +        # 3. Verify that volume snapshot fails with error 
    +                can not create volume snapshot for VM with VM-snapshot
    +
    +        """
    +        # Step 1
    +        # Create VM on cluster wide
    +        vm = VirtualMachine.create(
    +            self.userapiclient,
    +            self.testdata["small"],
    +            templateid=self.template.id,
    +            accountid=self.account.name,
    +            domainid=self.account.domainid,
    +            serviceofferingid=self.service_offering.id,
    +            zoneid=self.zone.id,
    +        )
    +        volumes_cluster_list = list_volumes(
    +                self.apiclient,
    +                virtualmachineid=vm.id,
    +                type='ROOT',
    +                listall=True
    +                )
    +
    +        volume_list_validation = validateList(volumes_cluster_list)
    +
    +        self.assertNotEqual(
    --- End diff --
    
    Updated testcase with review changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message