cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8616: Redundant VPC with both ...
Date Tue, 14 Jul 2015 15:14:20 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/587#discussion_r34579273
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsFile.py ---
    @@ -35,10 +35,9 @@ def load(self):
                     self.new_config.append(line)
             except IOError:
                 logging.debug("File %s does not exist" % self.filename)
    -            return
             else:
                 logging.debug("Reading file %s" % self.filename)
    -            self.config = copy.deepcopy(self.new_config)
    +            self.config = list(self.new_config)
    --- End diff --
    
    copy.deepcopy may be a necessary evil, if the list new_config contains objects. I wrote
an example to test this: https://gist.github.com/bhaisaab/fe85fb02e1a7fda2fd2d


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message