cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pavanb018 <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Handling Basic Zone scenarios for startin...
Date Thu, 09 Jul 2015 09:55:55 GMT
Github user pavanb018 commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/569#discussion_r34239937
  
    --- Diff: test/integration/component/test_blocker_bugs.py ---
    @@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
             #    all it's services should resume
     
             # Find router associated with user account
    -        list_router_response = list_routers(
    --- End diff --
    
    We already have the list_routers as wrapper function on top of the api building. This
function serves basic and advanced zone depending upon the passed arguments. Hence the same
is called depending on the network type check. Adding another function with network type as
a parameter might just be another wrapper that internally calls list_routers again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message