cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <>
Subject [GitHub] cloudstack pull request: Vpcr Marvin test and some fixes for vprc
Date Wed, 08 Jul 2015 08:37:31 GMT
Github user DaanHoogland commented on a diff in the pull request:
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/ ---
    @@ -407,10 +410,10 @@ def fw_vpcrouter(self):
             if self.get_type() in ["public"]:
    -            self.fw.append(["nat", "front",
    -                            "-A POSTROUTING -o %s -j SNAT --to-source %s" %
    -                           (, self.address['public_ip'])
    -                            ])
    +            # self.fw.append(["nat", "front",
    --- End diff --
    You can but you can also make a new pr inlcuding @isoutham code (with attribution intact)
and add ammending commits
    My worry is: will this break any existing tests. prod code is safe so I won't -1, just
looking for loopholes

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message