cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Cleaned class “com.cloud.hypervisor.xen...
Date Mon, 06 Jul 2015 09:45:46 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/560#issuecomment-118788393
  
    Hi @rafaelweingartner 
    
    The reason why the build failed can be found here: https://builds.apache.org/job/cloudstack-pull-requests/688/org.apache.cloudstack$cloud-plugin-hypervisor-xenserver/console
    
    To sum it up: your changes did not pass the audit due to tab entries in the code. That's
a code-style audit.
    
    Did you use Eclipse/IntelliJ to change the Java code? If so, you will need to change your
code settings to cope with 4-spaces instead of 1-tab. After that, you will have to format
your change and commit again to the same branch you used to create the PR. Jenkins should
be fine and we can proceed with testing/merging your changes.
    
    Cheers,
    Wilder
    
    Erros below:
    
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:38:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:40:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:41:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:42:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:43:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:44:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:45:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:46:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:47:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:48:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:49:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:50:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:51:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:52:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:54:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:55:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:56:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:57:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:58:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:59:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:60:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:61:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:62:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:63:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:64:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:66:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:67:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:68:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:69:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:70:1:
Line contains a tab character.
    /home/jenkins/jenkins-slave/workspace/cloudstack-pull-requests/plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XcpOssResource.java:71:1:
Line contains a tab character.
    Audit done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message