cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Vpcr Marvin test and some fixes for vprc
Date Mon, 06 Jul 2015 08:33:27 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/558#discussion_r33914408
  
    --- Diff: test/integration/component/test_vpc_redundant.py ---
    @@ -0,0 +1,506 @@
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +
    +""" Test redundancy features for VPC routers
    +"""
    +
    +from nose.plugins.attrib import attr
    +from marvin.cloudstackTestCase import cloudstackTestCase
    +from marvin.lib.base import (stopRouter,
    +                             startRouter,
    +                             Account,
    +                             VpcOffering,
    +                             VPC,
    +                             ServiceOffering,
    +                             NATRule,
    +                             NetworkACL,
    +                             PublicIPAddress,
    +                             NetworkOffering,
    +                             Network,
    +                             VirtualMachine,
    +                             LoadBalancerRule)
    +from marvin.lib.common import (get_domain,
    +                               get_zone,
    +                               get_template,
    +                               list_routers)
    +from marvin.lib.utils import cleanup_resources
    +import socket
    +import time
    +import inspect
    +
    +
    +class Services:
    --- End diff --
    
    Hi @sanju1010 
    
    @isoutham is currently on holidays and I would like to test and get this PR through before
he is back.
    
    I agree with the improvement you suggested, however it's not a blocking thing for the
PR because it's only related to the marvin test.
    
    Once his PR get's through, I will proceed with removing the Services class and use test_data.py
instead. A new PR will be created afterwards.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message