Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
From: ProjectMoon <git@git.apache.org>
To: dev@cloudstack.apache.org
Reply-To: dev@cloudstack.apache.org
Message-ID: <git-pr-354-cloudstack@git.apache.org>
Subject: [GitHub] cloudstack pull request: Allow custom command role ACL files
 on cl...
Content-Type: text/plain
Date: Wed,  3 Jun 2015 17:35:27 +0000 (UTC)

GitHub user ProjectMoon opened a pull request:

    https://github.com/apache/cloudstack/pull/354

    Allow custom command role ACL files on classpath in Static Role API Checker

    ## Commit Message
    This commit has a small refactoring of cloud-plugin-acl-static-role-based
    to allow it to read files on the classpath that might have a different name
    than "commands.properties". It also allows more than one file to be read from.
    
    Rationale: Third-party plugins may want to keep their API command access level
    configuration separate from the main file so as to reduce configuration
    maintenance work during packaging and deployments.
    
    ## Testing Performed
    Ran the simulator locally and connected to it with Cloudmonkey. Ran sync and then executed some API commands to verify that they are not blacklisted (i.e. not found because CS could not read the file on the classpath).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greenqloud/cloudstack master-gq

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/354.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #354
    
----
commit a97bfbbb35772f0f94afb4563a01a6adfc404ac0
Author: jeff <jeff@greenqloud.com>
Date:   2015-06-03T17:15:57Z

    Allow custom command role ACL files on classpath in Static Role API Checker.
    
    This commit has a small refactoring of cloud-plugin-acl-static-role-based
    to allow it to read files on the classpath that might have a different name
    than "commands.properties". It also allows more than one file to be read from.
    
    Rationale: Third-party plugins may want to keep their API command access level
    configuration separate from the main file so as to reduce configuration
    maintenance work during packaging and deployments.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---