cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsafonseca <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix findbugs ClassCastException in Upgrad...
Date Sun, 14 Jun 2015 13:27:26 GMT
GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/413

    Fix findbugs ClassCastException in UpgradeSystemVMCmd.java

    getDetails() isn't called anywhere in the code, either way, implementation is wrong since
details is a Map\<String, String\> and not a Map\<String, Map\<String,String\>\>
    If this piece of could would get run, it would just fail trying to cast String to HashMap\<String,String\>
in line 83

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs30

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/413.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #413
    
----
commit a232820b8cbc79e3cf4ba298daf8885c811c2f55
Author: Rafael da Fonseca <rsafonseca@gmail.com>
Date:   2015-06-14T13:25:33Z

    Fix findbugs ClassCastException in UpgradeSystemVMCmd.java
    getDetails() isn't called anywhere in the code, either way, implementation is wrong since
details is a Map<String, String> and not a Map<String, Map<String,String>>
    If this piece of could would get run, it would just fail trying to cast String to HashMap<String,String>
in line 83

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message