cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsafonseca <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix findbugs warning in LibvirtConsolePro...
Date Fri, 12 Jun 2015 23:50:06 GMT
GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/400

    Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper

    Encoding is now specified in both server and clients for the console proxy getstatus command
    For some reason, findbugs did not detect unsafe encoding issue in ConsoleProxyResource.java,
is properly specified now though...
    CitrixConsoleProxyLoadCommandWrapper was specifying system default encoding for operation,
should be ok because default for xenserver is UTF-8 since it's linux based, but it's best
to specify exact encoding set on the server end to be consistent

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs17

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #400
    
----
commit 730ec2b877c36955c596188c02f33f28b7a3c655
Author: Rafael da Fonseca <rsafonseca@gmail.com>
Date:   2015-06-12T23:46:26Z

    Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper
    Encoding is now specified in both server and clients for the console proxy getstatus command
    For some reason, findbugs did not detect unsafe encoding issue in ConsoleProxyResource.java,
is properly specified now though...
    CitrixConsoleProxyLoadCommandWrapper was specifying system default encoding for operation,
should be ok because default for xenserver is UTF-8 since it's linux based, but it's best
to specify exact encoding set on the server end to be consistent

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message