cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsafonseca <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix 4 findbugs warnings in JuniperSrxReso...
Date Fri, 12 Jun 2015 23:24:19 GMT
GitHub user rsafonseca opened a pull request:

    https://github.com/apache/cloudstack/pull/399

    Fix 4 findbugs warnings in JuniperSrxResource

    Data should be read and written in UTF-8 to the SRX
    Buffers were being used for reading but not for writing, PrintWriter was auto-flushing
and code was explicitly flushing again, causing unnecessary operation to be performed.
    Some operations might fail in OS that didn't use UTF-8 as default encoding, such as windows.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rsafonseca/cloudstack findbugs16

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #399
    
----
commit 4cdc5813afa9b48e87cca0eac041323fe784ffc8
Author: Rafael da Fonseca <rsafonseca@gmail.com>
Date:   2015-06-12T23:19:39Z

    Fix 4 findbugs warnings in JuniperSrxResource
    Data should be read and written in UTF-8 to the SRX
    Buffers were being used for reading but not for writing, PrintWriter was auto-flushing
and code was explicitly flushing again, causing unnecessary operation to be performed.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message