cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Weber <terbol...@gmail.com>
Subject Re: [PROPOSAL] Commit to master through PR only
Date Fri, 26 Jun 2015 08:14:13 GMT
On Thu, Jun 25, 2015 at 4:38 PM, Sebastien Goasguen <runseb@gmail.com>
wrote:

> Folks,
>
> A few of us are in Amsterdam at DevOps days. We are chatting about release
> management procedure.
> Remi is working on a set of principles that he will put on the wiki to
> start a [DISCUSS].
>
> However to get started on the right track. I would like to propose the
> following easy step:
>
> Starting Monday June 29th (next monday):
>
> - Only commit through PR will land on master (after a minimum of 2 LGTM
> and green Travis results)
> - Direct commit will be reverted
> - Any committer can merge the PR.
>
> Goal being to start having a new practice -everything through PR for
> everyone- which is an easy way to gate our own commits building up to a PR.
>
> There is no tooling involved, just human agreement.
>
>
If I were to add anything, it would be that all bug fixes should reference
a Jira issue, and that new features / major improvements should have a FS
(+ Jira ticket).

Trivial fixes (typos etc), docs, regarding travis/ci etc. is fine without
Jira tickets imho.

-- 
Erik

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message