cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: As an operator I want to be able to chang...
Date Mon, 29 Jun 2015 09:07:10 GMT
Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/527#issuecomment-116545842
  
    I created the issue and added to the last commit. Did it last week:
    
    https://issues.apache.org/jira/browse/CLOUDSTACK-8589
    
    Perhaps you missed that.
    
    Concerning squashed commits, ew should really have discussed about it when you were here.
I'm 100% if I squash my atomic commits next time you guys will complain. It seems I haven't
been clear enough about that yet.
    
    @remibergsma @miguelaferreira Would you guys give your input on these "squash commits"
matter? I'm a bit tired of this discussion. For me, squashed commits won't make a review easier,
unless there is no review at all or if the committer has changes a couple of lines in a bash
script.
    
    What I would like to see is people testing changes the way I do.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message