cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsafonseca <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix 2 findbugs SQL_PREPARED_STATEMENT_GEN...
Date Thu, 18 Jun 2015 10:06:32 GMT
Github user rsafonseca commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/476#discussion_r32715161
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long podId) {
                     dbName = "cloud";
                 }
     
    -            String selectSql = "SELECT * FROM `" + dbName + "`.`" + tableName + "` WHERE
" + column + " = ?";
    +            String selectSql = "SELECT * FROM `?`.`?` WHERE ? = ?";
     
                 if(tableName.equals("vm_instance")) {
                     selectSql += " AND state != '" + VirtualMachine.State.Expunging.toString()
+ "' AND removed IS NULL";
    --- End diff --
    
    shouldn't be necessary :)
    findbugs is smart enough to check that the returned string is static and cannot be polluted
by user input
    that's only not the case for other variables that it can't track the origin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message