cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rsafonseca <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Fix findbugs SQL_PREPARED_STATEMENT_GENER...
Date Wed, 17 Jun 2015 19:17:16 GMT
Github user rsafonseca commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/473#discussion_r32663864
  
    --- Diff: engine/schema/src/com/cloud/vm/dao/UserVmDaoImpl.java ---
    @@ -645,8 +643,9 @@ public boolean remove(Long id) {
     
             PreparedStatement pstmt = null;
             try {
    -            pstmt = txn.prepareStatement(VMS_DETAIL_BY_NAME + detail + VMS_DETAIL_BY_NAME2
+ getQueryBatchAppender(vmNames.size()));
    -            int i = 1;
    +            pstmt = txn.prepareStatement(VMS_DETAIL_BY_NAME + getQueryBatchAppender(vmNames.size()));
    --- End diff --
    
    Yes, it fixes it :)
    Did a local build to check.. findbugs is smart enough to check that getQueryBatchAppender
only adds static " ?,"  string


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message