cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: [GitHub] cloudstack pull request: return a state instead of null in Abstrac...
Date Fri, 01 May 2015 13:52:30 GMT
I finally got around a further code analysis and must conclude that
returning ALERT is no problem.

Status testIpAddress(Long hostId, String testHostIp), is called twice and
in both cases null is checked for avoiding NPE and next only the cases UP
and DOWN are handled. So the behaviour on a null return is ignoring and as
such same as the new returns at the moment.


effectively the result (and objective) of the commit is only the clearer
log messages. This enables alerting via 3rd party alerting (pager duty)
systems.


Hope this convinces you all.




Op vr 1 mei 2015 om 14:53 schreef DaanHoogland <git@git.apache.org>:

> Github user DaanHoogland commented on the pull request:
>
>     https://github.com/apache/cloudstack/pull/211#issuecomment-98127447
>
>     Please don't revert. It is on the 4.4 branch as well. It passes all
> tests and we have yet to create a test that show this hypothetical
> regression. If we have I'll fix forward.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message