cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wilderrodrigues <...@git.apache.org>
Subject [GitHub] cloudstack pull request: CLOUDSTACK-8506 - Make ACS compliant with...
Date Sat, 23 May 2015 08:53:13 GMT
Github user wilderrodrigues commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/292#discussion_r30943291
  
    --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java ---
    @@ -3556,6 +3556,11 @@ private void checkPublicIpRangeErrors(long zoneId, String vlanId,
String vlanGat
                 throw new InvalidParameterValueException("Please ensure that your end IP
is in the same subnet as your IP range's gateway, as per the IP range's netmask.");
             }
             // check if the gatewayip is the part of the ip range being added.
    +        // RFC 3021 - 31-Bit Prefixes on IPv4 Point-to-Point Links
    --- End diff --
    
    I talked to Remi yesterday and we agreed that would be nice to comment on the code so
people don't remove the functionality by mistake or at least will make sure it still works
if changes are made.
    
    By fixing the bug CLOUDSTACK-4811 on October 2013, it made the /31 not work anymore.
    
    The comment causes no harm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message