cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bhaisaab <...@git.apache.org>
Subject [GitHub] cloudstack pull request: Pep8 and some unit tests
Date Wed, 20 May 2015 08:54:51 GMT
Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/265#discussion_r30681931
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -555,35 +558,47 @@ def forward_vr(self, rule):
                     self.portsToString(rule['internal_ports'], '-')
                   )
             fw4 = "-j SNAT --to-source %s -A POSTROUTING -s %s -d %s/32 -o %s -p %s -m %s
--dport %s" % \
    -              ( self.getGatewayByIp(rule['internal_ip']),
    +              (
    +                self.getGatewayByIp(rule['internal_ip']),
                     self.getNetworkByIp(rule['internal_ip']),
                     rule['internal_ip'],
                     self.getDeviceByIp(rule['internal_ip']),
                     rule['protocol'],
                     rule['protocol'],
                     self.portsToString(rule['internal_ports'], ':')
    -              )  
    +              )
             fw5 = "-A PREROUTING -d %s/32 -i %s -p %s -m %s --dport %s -j MARK --set-xmark
%s/0xffffffff" % \
    -              ( rule['public_ip'],
    +              (
    +                rule['public_ip'],
                     self.getDeviceByIp(rule['public_ip']),
                     rule['protocol'],
                     rule['protocol'],
                     self.portsToString(rule['public_ports'], ':'),
                     hex(int(self.getDeviceByIp(rule['public_ip'])[3:]))
    -              )  
    +              )
             fw6 = "-A PREROUTING -d %s/32 -i %s -p %s -m %s --dport %s -m state --state NEW
-j CONNMARK --save-mark --nfmask 0xffffffff --ctmask 0xffffffff" % \
    -              ( rule['public_ip'],
    +              (
    +                rule['public_ip'],
                     self.getDeviceByIp(rule['public_ip']),
                     rule['protocol'],
                     rule['protocol'],
                     self.portsToString(rule['public_ports'], ':'),
    -              )  
    +              )
    +        fw7 = "-A FORWARD -i %s -o %s -p %s -m %s --dport %s -m state --state NEW -j
ACCEPT" % \
    --- End diff --
    
    @isoutham this PR says pep8/unit test fixes, why are we adding a forwarding rule here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message