cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DaanHoogland <...@git.apache.org>
Subject [GitHub] cloudstack pull request: backport of CLOUDSTACK-8197 create MinVRV...
Date Tue, 12 May 2015 11:03:07 GMT
Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/244#discussion_r30123159
  
    --- Diff: engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
---
    @@ -62,9 +63,13 @@
         static final String NetworkLockTimeoutCK = "network.lock.timeout";
         static final String GuestDomainSuffixCK = "guest.domain.suffix";
         static final String NetworkThrottlingRateCK = "network.throttling.rate";
    +    static final String MinVRVersionCK = "minreq.sysvmtemplate.version";
    +
    +    static final ConfigKey<String> MinVRVersion = new ConfigKey<String>(String.class,
MinVRVersionCK, "Advanced", "4.5.2",
    --- End diff --
    
    Fine
    
    On Tue, 12 May 2015 12:54 Rohit Yadav <notifications@github.com> wrote:
    
    > In
    > engine/api/src/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java
    > <https://github.com/apache/cloudstack/pull/244#discussion_r30122724>:
    >
    > > @@ -62,9 +63,13 @@
    > >      static final String NetworkLockTimeoutCK = "network.lock.timeout";
    > >      static final String GuestDomainSuffixCK = "guest.domain.suffix";
    > >      static final String NetworkThrottlingRateCK = "network.throttling.rate";
    > > +    static final String MinVRVersionCK = "minreq.sysvmtemplate.version";
    > > +
    > > +    static final ConfigKey<String> MinVRVersion = new ConfigKey<String>(String.class,
MinVRVersionCK, "Advanced", "4.5.2",
    >
    > I guess all 4.5.x releases should support 4.5.0 as minimum VR version? so
    > can we change this to 4.5.0?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > <https://github.com/apache/cloudstack/pull/244/files#r30122724>.
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message