cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abhinandanprateek <...@git.apache.org>
Subject [GitHub] cloudstack pull request: return a state instead of null in Abstrac...
Date Fri, 01 May 2015 10:17:29 GMT
Github user abhinandanprateek commented on the pull request:

    https://github.com/apache/cloudstack/pull/211#issuecomment-98093700
  
    Daan, 
      Yes, I agree. We can define a proper state and introduce it. I guess there is some tribal
knowledge involved here that Koushik and myself were trying to convey. The HA related timeouts
are very delicately balanced. On further looking at the code around the commit, my guess is
it actually does not make difference to code-flow. But we should replace the "null" with say
a new state like "UNKNOWN" and make sure that it is handled in the call hierarchy.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message